-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align few crates versions #4374
Conversation
e4a8859
to
8da46d4
Compare
f360eb1
to
427d373
Compare
Sorry, add a few more. This is enough for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to not just switch to workspace deps?
if you guys want, I can help to switch to workspace deps |
Yea it would probably make more sense to pull them up first. Hope it can be automated like here: #3366 |
Do you have any rules about which crates should be kept in the project's own |
Prob only if they would never be used in any other crate, I can't think of any examples. |
Understood, I'll do it later. |
One thing to keep in mind that larger merge-requests normally take longer to review. We had a few sledge-hammer merge requests that ended up abandoned since the tried to do too much at once. |
Understood, I'll separate changes to small pieces |
c9e8b66
to
c3ea462
Compare
This should cover most, I'll split them tomorrow, and close this one |
I'd still make this a workspace dep, the dep is general and just because it isn't used by any other package today doesn't mean that won't change in the future |
5261e75
to
a469be6
Compare
Split from #4374 This PR helps to reduce dependencies and align versions, which would help to move them to workspace dep
Split from paritytech#4374 This PR helps to reduce dependencies and align versions, which would help to move them to workspace dep
Split from paritytech#4374 This PR helps to reduce dependencies and align versions, which would help to move them to workspace dep
Closes #3414
@bkchr Here it is, I miss that DependentBot breaks compiling.
I also found there are a few dependencies in the codebase that use different versions.
This PR aims to align them to the highest version (in the code base)
I separate them into individual commits, so I can remove the changes you don't like