Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge: check bridge GRANDPA pallet call limits from signed extension #4385

Merged
merged 1 commit into from
May 8, 2024

Conversation

svyatonik
Copy link
Contributor

silent, because it'll be deployed with the #4102, where this code has been introduced

I've planned originally to avoid doing that check in the runtime code, because it may be checked offchain. But actually, the check is quite cheap and we could do that onchain too.

@svyatonik svyatonik added R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges. labels May 6, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 6, 2024 11:05
@acatangiu acatangiu added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 17b56fa May 8, 2024
156 checks passed
@acatangiu acatangiu deleted the sv-check-grandpa-call-limits-from-extension branch May 8, 2024 08:49
paritytech-ci pushed a commit that referenced this pull request May 8, 2024
…#4385)

silent, because it'll be deployed with the
#4102, where this code
has been introduced

I've planned originally to avoid doing that check in the runtime code,
because it **may be** checked offchain. But actually, the check is quite
cheap and we could do that onchain too.
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
…paritytech#4385)

silent, because it'll be deployed with the
paritytech#4102, where this code
has been introduced

I've planned originally to avoid doing that check in the runtime code,
because it **may be** checked offchain. But actually, the check is quite
cheap and we could do that onchain too.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
…paritytech#4385)

silent, because it'll be deployed with the
paritytech#4102, where this code
has been introduced

I've planned originally to avoid doing that check in the runtime code,
because it **may be** checked offchain. But actually, the check is quite
cheap and we could do that onchain too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T15-bridges This PR/Issue is related to bridges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants