Code coverage preparations #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndWeHaveAPlan
added
A1-insubstantial
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filesContinue to review full report in Codecov by Sentry.
|
rcny
approved these changes
May 6, 2024
alvicsam
approved these changes
May 6, 2024
Closed
paritytech-ci
pushed a commit
that referenced
this pull request
May 8, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage #902](paritytech/ci_cd#902)
|
I looked at https://app.codecov.io/gh/paritytech/polkadot-sdk. Is it correct that we only have 5% coverage? that looks unlikely. |
hitchhooker
pushed a commit
to ibp-network/polkadot-sdk
that referenced
this pull request
Jun 5, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](paritytech#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
Added manual jobs for code coverage (triggered via `codecov-start` job): - **codecov-start** - initialize Codecov report for commit/pr - **test-linux-stable-codecov** - perform `nextest run` and upload coverage data parts - **codecov-finish** - finalize uploading of data parts and generate Codecov report Coverage requires code to be built with `-C instrument-coverage` which causes build errors (e .g. ```error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\` ```, seems like related to [2641](paritytech#2641)) and unstable tests behavior ([example](https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6004731)). This is where we'll nee the developers assistance closing [[polkadot-sdk] Add code coverage paritytech#902](https://github.com/paritytech/ci_cd/issues/902)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added manual jobs for code coverage (triggered via
codecov-startjob):nextest runand upload coverage data partsCoverage requires code to be built with
-C instrument-coveragewhich causes build errors (e .g.error[E0275]: overflow evaluating the requirement `<mock::Test as pallet::Config>::KeyOwnerProof == _\`, seems like related to 2641) and unstable tests behavior (example). This is where we'll nee the developers assistanceclosing [polkadot-sdk] Add code coverage #902