Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate XCM weights for coretimes #4396

Merged
merged 8 commits into from
May 7, 2024
Merged

Generate XCM weights for coretimes #4396

merged 8 commits into from
May 7, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented May 7, 2024

Addressing comment: #3455 (comment)

@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label May 7, 2024
@bkontur
Copy link
Contributor Author

bkontur commented May 7, 2024

bot help

@command-bot
Copy link

command-bot bot commented May 7, 2024

Here's a link to docs

@bkontur
Copy link
Contributor Author

bkontur commented May 7, 2024

bot bench cumulus-coretime --runtime=coretime-rococo --pallet=pallet_xcm
bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_xcm
bot bench cumulus-coretime --runtime=coretime-rococo --pallet=pallet_xcm_benchmarks::generic --subcommand=xcm
bot bench cumulus-coretime --runtime=coretime-rococo --pallet=pallet_xcm_benchmarks::fungible --subcommand=xcm
bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_xcm_benchmarks::generic --subcommand=xcm
bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_xcm_benchmarks::fungible --subcommand=xcm

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144613 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-11cd5fe0-9698-4abd-ba14-f7bb8710174a to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144614 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-3f07e687-9577-4716-8d65-4d0ee0002fe0 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144739 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 4-e4dbd5c4-724d-4f76-a653-c3fbbfcaf17c to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144740 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 5-34ed03cb-7cf7-4dee-af71-e390a8ec53e2 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144741 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 6-8dc921db-f580-472b-8b94-f969bcc18606 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144742 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-53f69eef-ab9c-4304-896c-b58ee2bfdbfc to cancel this command or bot cancel to cancel all commands in this pull request.

…=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm
@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144614 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144614/artifacts/download.

command-bot added 2 commits May 7, 2024 09:38
…retime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible
…retime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic
@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144740 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144740/artifacts/download.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144739 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144739/artifacts/download.

…=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm
@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=coretime-rococo --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144613 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144613/artifacts/download.

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144742 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144742/artifacts/download.

…retime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic
@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::generic has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144741 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6144741/artifacts/download.

@bkontur
Copy link
Contributor Author

bkontur commented May 7, 2024

bot bench cumulus-coretime --runtime=coretime-westend --pallet=pallet_xcm_benchmarks::fungible --subcommand=xcm

@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6146103 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 8-172a39bb-9c12-404d-bb1b-be15b10cfa66 to cancel this command or bot cancel to cancel all commands in this pull request.

command-bot added 2 commits May 7, 2024 10:02
…retime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible
@command-bot
Copy link

command-bot bot commented May 7, 2024

@bkontur Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=xcm --runtime=coretime-westend --runtime_dir=coretime --target_dir=cumulus --pallet=pallet_xcm_benchmarks::fungible has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6146103 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6146103/artifacts/download.

@bkontur bkontur requested a review from seadanda May 7, 2024 11:06
@bkontur bkontur enabled auto-merge May 7, 2024 11:54
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compare link LGTM.

@bkontur bkontur added this pull request to the merge queue May 7, 2024
@bkontur
Copy link
Contributor Author

bkontur commented May 7, 2024

Compare link LGTM.

@ggwpez cool, thank you for the link, just one question "Rel. Change" calculates max +/-100%? because the last rows are much more than -100%:

18446744.07s 	826.26us 	 -100.00%

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@bkontur bkontur added this pull request to the merge queue May 7, 2024
Merged via the queue into master with commit c91c13b May 7, 2024
151 checks passed
@bkontur bkontur deleted the bko-coretime-weights branch May 7, 2024 22:16
paritytech-ci pushed a commit that referenced this pull request May 8, 2024
Addressing comment:
#3455 (comment)

---------

Co-authored-by: command-bot <>
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
Addressing comment:
paritytech#3455 (comment)

---------

Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
Addressing comment:
paritytech#3455 (comment)

---------

Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants