Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckMetadataHash extension backport to 1.8.0 #4580

Merged
merged 2 commits into from
May 28, 2024

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented May 25, 2024

No description provided.

bkchr and others added 2 commits May 22, 2024 21:57
Basically combines all the recommended calls into one
`build_using_defaults()` call or `init_with_defaults()` when there are
some custom changes required.
This implements the `CheckMetadataHash` extension as described in
[RFC78](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html).

Besides the signed extension, the `substrate-wasm-builder` is extended
to support generating the metadata-hash.

Closes: #291

---------

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>
Co-authored-by: Liam Aharon <liam.aharon@hotmail.com>
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label May 25, 2024
@bkchr bkchr requested review from a team and koute as code owners May 25, 2024 09:28
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6294831

@bkchr bkchr merged commit a51b5dd into release-polkadot-v1.8.0 May 28, 2024
31 of 131 checks passed
@bkchr bkchr deleted the bkchr-metadata-hash-1.8.0 branch May 28, 2024 09:58
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 26, 2024
Add a new signed extension that enables the metadata hash verification feature approved under [RFC 0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata). This enhancement will support the new generic ledger hardware wallet app and future hardware wallets within the Polkadot ecosystem.

[Reference implementation](paritytech/polkadot-sdk#4580)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 29, 2024
Add a new signed extension that enables the metadata hash verification feature approved under [RFC 0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata). This enhancement will support the new generic ledger hardware wallet app and future hardware wallets within the Polkadot ecosystem.

[Reference implementation](paritytech/polkadot-sdk#4580)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 29, 2024
Add a new signed extension that enables the metadata hash verification feature approved under [RFC 0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata). This enhancement will support the new generic ledger hardware wallet app and future hardware wallets within the Polkadot ecosystem.

[Reference implementation](paritytech/polkadot-sdk#4580)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
Add a new signed extension that enables the metadata hash verification feature approved under [RFC 0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata). This enhancement will support the new generic ledger hardware wallet app and future hardware wallets within the Polkadot ecosystem.

[Reference implementation](paritytech/polkadot-sdk#4580)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
Add a new signed extension that enables the metadata hash verification feature approved under [RFC 0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata). This enhancement will support the new generic ledger hardware wallet app and future hardware wallets within the Polkadot ecosystem.

[Reference implementation](paritytech/polkadot-sdk#4580)
enddynayn added a commit to frequency-chain/frequency that referenced this pull request Jul 30, 2024
Add a new signed extension that enables the metadata hash verification
feature approved under [RFC
0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata).
This enhancement will support the new generic ledger hardware wallet app
and future hardware wallets within the Polkadot ecosystem.

[Reference
implementation](paritytech/polkadot-sdk#4580)
rustadot pushed a commit to rustadot/recurrency that referenced this pull request Sep 5, 2024
Add a new signed extension that enables the metadata hash verification
feature approved under [RFC
0078](https://polkadot-fellows.github.io/RFCs/approved/0078-merkleized-metadata.html#rfc-0078-merkleized-metadata).
This enhancement will support the new generic ledger hardware wallet app
and future hardware wallets within the Polkadot ecosystem.

[Reference
implementation](paritytech/polkadot-sdk#4580)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants