Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5 / 5] Introduce approval-voting-parallel #4849

Merged
merged 73 commits into from
Sep 26, 2024
Merged

[5 / 5] Introduce approval-voting-parallel #4849

merged 73 commits into from
Sep 26, 2024

Commits on Jul 16, 2024

  1. Make approval-distribution logic runnable on a separate thread 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    8dbb088 View commit details
    Browse the repository at this point in the history

  2. Move crypto checks in the approval-distribution 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    14727c5 View commit details
    Browse the repository at this point in the history

  3. Make approval-voting runable on a worker thread 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    1942139 View commit details
    Browse the repository at this point in the history

  4. Introduce approval-voting-parallel 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    55520b8 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Address review feedback 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    7175957 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-1-5' into alexaggh/approval-voting-parallel-3-5
    @alexggh
    alexggh committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    469866f View commit details
    Browse the repository at this point in the history

  3. Address review feedback 

    - rename check_and_import in import.
- refactor un-needed variable.

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    d9fdd51 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-3-5' into alexaggh/approval-voting-parallel-2-5
    @alexggh
    alexggh committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    135fe79 View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-2-5' into alexaggh/approval-voting-parallel-5-5
    @alexggh
    alexggh committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    27bab6e View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Fail early on oversized claims 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2752d6e View commit details
    Browse the repository at this point in the history

  2. Add more unittests 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    00d22ee View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-3-5
    @alexggh
    alexggh committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    4f99f65 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-3-5' into alexaggh/approval-voting-parallel-2-5
    @alexggh
    alexggh committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    f289995 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-2-5' into alexaggh/approval-voting-parallel-5-5
    @alexggh
    alexggh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    57472ae View commit details
    Browse the repository at this point in the history

  2. Some refactoring to make the code a bit more testable 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    00dbcb0 View commit details
    Browse the repository at this point in the history

  3. Move gather of assignments on separate task 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    f42fbf6 View commit details
    Browse the repository at this point in the history

  4. Some nits 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    57534a7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Add metrics for channels to workers 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    d920095 View commit details
    Browse the repository at this point in the history

  2. subsystem-bench: Make it report per task cpu usage 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    e30f83d View commit details
    Browse the repository at this point in the history

  3. Make subsystem-bench run in both parallel and single thread mode 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    05c53cd View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Add some documentation 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    493116f View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Add subsystem unittests 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    bb4ca09 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. Add more unittests 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    83d65f7 View commit details
    Browse the repository at this point in the history

  2. Add zombienet for running approval-voting-in parallel 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    3e4821e View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2024

  1. Review feedback 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ead49d2 View commit details
    Browse the repository at this point in the history

  2. Add checked indirect assignment 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    c67d99d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-3-5' into alexaggh/approval-voting-parallel-2-5
    @alexggh
    alexggh committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    23d5a28 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-2-5' into alexaggh/approval-voting-parallel-5-5
    @alexggh
    alexggh committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    638c4ad View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-3-5
    @alexggh
    alexggh committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    247161f View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-3-5' into alexaggh/approval-voting-parallel-2-5
    @alexggh
    alexggh committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    edd7898 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/alexaggh/approval-voting-paralle… 

    …l-2-5' into alexaggh/approval-voting-parallel-5-5
    @alexggh
    alexggh committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    50ac4cc View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Change OurViewChange order 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0b140cc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'fix_signal_order' into alexaggh/approval-voting-paralle… 

    …l-3-5
    @alexggh
    alexggh committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    0581468 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-3-5
    @alexggh
    alexggh committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    08889e1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'alexaggh/approval-voting-parallel-3-5' into alexaggh/ap… 

    …proval-voting-parallel-2-5
    @alexggh
    alexggh committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    d04d4cc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'alexaggh/approval-voting-parallel-2-5' into alexaggh/ap… 

    …proval-voting-parallel-5-5
    @alexggh
    alexggh committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a3c4735 View commit details
    Browse the repository at this point in the history

  4. Update Cargo.lock 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    c6157b6 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-3-5
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    b0fb6d4 View commit details
    Browse the repository at this point in the history

  2. Remove crate dependency between approval-distribution and approval-vo… 

    …ting

Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    7539184 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'alexaggh/approval-voting-parallel-3-5' into alexaggh/ap… 

    …proval-voting-parallel-2-5
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8da0be8 View commit details
    Browse the repository at this point in the history

  4. Address review feedback 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    377f4e1 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'alexaggh/approval-voting-parallel-2-5' into alexaggh/ap… 

    …proval-voting-parallel-5-5
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    6d7ed3a View commit details
    Browse the repository at this point in the history

  6. Make subsystem-bench happy 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3b3299e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-2-5
    @alexggh
    alexggh committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    f5a2447 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'alexaggh/approval-voting-parallel-2-5' into alexaggh/ap… 

    …proval-voting-parallel-5-5
    @alexggh
    alexggh committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    16652b3 View commit details
    Browse the repository at this point in the history

  3. Address review feedback 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    3fe4076 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. Remove subsystem_enabled and subystem_disabled flags 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    df08769 View commit details
    Browse the repository at this point in the history

  2. Fix benchmark 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fab18b1 View commit details
    Browse the repository at this point in the history

  3. Enable it by default on all test networks except kusama and polkadot 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a7d5f85 View commit details
    Browse the repository at this point in the history

  4. Cosmetic updates 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    11cc977 View commit details
    Browse the repository at this point in the history

  5. Reduce timeout 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    bb3887f View commit details
    Browse the repository at this point in the history

  6. Cleanup Cargo.toml 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b817677 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Add option to capacity override the workers channels 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6521bb9 View commit details
    Browse the repository at this point in the history

  2. Add qed to expect. 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a2bfe6b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-5-5
    @alexggh
    alexggh committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    0f95717 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Fix some typos 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e4f8771 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Fix cargo fmt 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f6c58b9 View commit details
    Browse the repository at this point in the history

  2. Add prdoc 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    f356912 View commit details
    Browse the repository at this point in the history

  3. Add implementers guide documenation for the new subsystem 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e19d8dc View commit details
    Browse the repository at this point in the history

  4. Fix gum reference 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ae0a087 View commit details
    Browse the repository at this point in the history

  5. Make cargo doc happy 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2b6e5c6 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin/master' into alexaggh/approval-v… 

    …oting-parallel-5-5
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    808e8d0 View commit details
    Browse the repository at this point in the history

  7. Update Cargo.lock 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cecb78d View commit details
    Browse the repository at this point in the history

  8. Make taplo happy 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    18facc1 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2024

  1. Send GetApprovalSignatures on unbounded 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    89ef3fa View commit details
    Browse the repository at this point in the history

  2. Fix failing unittest 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    64be040 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Make umbrella check happy 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    19816a7 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Merge branch 'master' into alexaggh/approval-voting-parallel-5-5

    @alexggh
    alexggh authored Sep 24, 2024
    Configuration menu
    Copy the full SHA
    ee31fb0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Make tests less verbose 

    Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
    @alexggh
    alexggh committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2486214 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Merge branch 'master' into alexaggh/approval-voting-parallel-5-5

    @alexggh
    alexggh authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    da175b9 View commit details
    Browse the repository at this point in the history

  2. Update pr_4849.prdoc

    @alexggh
    alexggh authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    dca783a View commit details
    Browse the repository at this point in the history

  3. Update pr_4849.prdoc

    @alexggh
    alexggh authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d88c8cd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into alexaggh/approval-voting-parallel-5-5

    @alexggh
    alexggh authored Sep 26, 2024
    Configuration menu
    Copy the full SHA
    a818d96 View commit details
    Browse the repository at this point in the history