Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: export NodeHealthProxyLayer #5768

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: export NodeHealthProxyLayer #5768

wants to merge 4 commits into from
+11 −2

Conversation

yjhmelody
Copy link
Contributor

No description provided.

niklasad1
niklasad1 reviewed Sep 19, 2024
View reviewed changes
substrate/client/rpc-servers/src/lib.rs
@@ -43,7 +42,7 @@ pub use jsonrpsee::{
core::id_providers::{RandomIntegerIdProvider, RandomStringIdProvider},
server::{middleware::rpc::RpcServiceBuilder, BatchRequestConfig},
};
pub use middleware::{Metrics, MiddlewareLayer, RpcMetrics};
pub use middleware::{Metrics, MiddlewareLayer, NodeHealthProxyLayer, RpcMetrics};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it useful to export the middleware implementation?
it's not possible to opt in/out from it anyway?

Copy link
Contributor Author

@yjhmelody yjhmelody Sep 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to reimpl these rpc-servers and wanna add more layer.
Current, start_server could not add more layers for http.
So need to define the another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow, you want to write your own start server or an API to inject your own http middleware?
Anyway, doesn't hurt to re-export it from my-side

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to write an issue which what functionality you want.

We could expose APIs for folks to inject their own middleware both http and rpc... but it's a little tricky to get the traits bounds satisfied properly.

@niklasad1 niklasad1 added the T0-node This PR/Issue is related to the topic “node”. label Sep 23, 2024
@bkchr
Copy link
Member

bkchr commented Sep 23, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Sep 23, 2024 •
edited
Loading

@bkchr https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7410937 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-4877bc31-fc69-4603-9ce1-7d9d2f512fb3 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Sep 23, 2024

@bkchr Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7410937 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7410937/artifacts/download.

@bkchr bkchr added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yjhmelody @bkchr @niklasad1