-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pallet-revive] Eth RPC integration #5866
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgherveou
force-pushed
the
pg/revive-rpc-fixes-v2
branch
4 times, most recently
from
September 30, 2024 14:49
16c7f99
to
c58e6a5
Compare
pgherveou
force-pushed
the
pg/revive-rpc-fixes-v2
branch
from
September 30, 2024 14:52
c58e6a5
to
4f4efcc
Compare
pgherveou
added
R0-silent
Changes should not be mentioned in any release notes
T7-smart_contracts
This PR/Issue is related to smart contracts.
labels
Sep 30, 2024
pgherveou
commented
Sep 30, 2024
pgherveou
force-pushed
the
pg/revive-rpc-fixes-v2
branch
from
October 4, 2024 12:45
f81bf25
to
dd56741
Compare
athei
approved these changes
Oct 21, 2024
xermicus
approved these changes
Oct 22, 2024
Co-authored-by: Cyrill Leutwiler <cyrill@parity.io>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
R0-silent
Changes should not be mentioned in any release notes
T7-smart_contracts
This PR/Issue is related to smart contracts.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the necessary changes to pallet-revive for integrating with our Ethereum JSON-RPC.
The RPC proxy itself will be added in a follow up.
Changes
A new pallet::call
Call::eth_transact
. This is used as a wrapper to accept unsigned Ethereum transaction, valid call will be routed toCall::call
orCall::instantiate_with_code
A custom UncheckedExtrinsic struct, that wraps the generic one usually and add the ability to check eth_transact calls sent from an Ethereum JSON-RPC proxy.
Generated types and traits to support implementing a JSON-RPC Ethereum proxy.
Flow Overview:
Dependencies
Follow up PRs