-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Move build and publish rustdocs to GHA #6047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
added
the
R0-silent
Changes should not be mentioned in any release notes
label
Oct 14, 2024
AndWeHaveAPlan
approved these changes
Oct 14, 2024
alvicsam
changed the title
[ci] Move build and publish rustocs to GHA
[ci] Move build and publish rustdocs to GHA
Oct 14, 2024
Bullrich
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this superseed #5553?
@Bullrich yes and no. At this point I'd like to merge it this way but in the future I might use your solution to push changes related to |
lovelaced
approved these changes
Oct 15, 2024
EgorPopelyaev
approved these changes
Oct 15, 2024
My last PR was merged 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR moves jobs
build-rustdoc
,test-doc
andpublish-rustdoc
to GHA.publish-rustdoc
was changed so it can publish changes using token from GH APP.PR removes
test-rustdoc
because the same command in executed inbuild-rustdoc
and I see no reason to run it twice.cc https://github.com/paritytech/ci_cd/issues/1006