Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Move build and publish rustdocs to GHA #6047

Merged
merged 6 commits into from
Oct 15, 2024
Merged

[ci] Move build and publish rustdocs to GHA #6047

merged 6 commits into from
Oct 15, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam commented Oct 14, 2024

PR moves jobs build-rustdoc, test-doc and publish-rustdoc to GHA. publish-rustdoc was changed so it can publish changes using token from GH APP.
PR removes test-rustdoc because the same command in executed in build-rustdoc and I see no reason to run it twice.

cc https://github.com/paritytech/ci_cd/issues/1006

@alvicsam alvicsam requested review from a team as code owners October 14, 2024 13:23
@alvicsam alvicsam added the R0-silent Changes should not be mentioned in any release notes label Oct 14, 2024
@alvicsam alvicsam changed the title [ci] Move build and publish rustocs to GHA [ci] Move build and publish rustdocs to GHA Oct 14, 2024
Copy link
Contributor

@Bullrich Bullrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this superseed #5553?

@alvicsam
Copy link
Contributor Author

@Bullrich yes and no. At this point I'd like to merge it this way but in the future I might use your solution to push changes related to gh-pages.

@alvicsam alvicsam added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 4edb219 Oct 15, 2024
194 checks passed
@alvicsam alvicsam deleted the as-push-docs branch October 15, 2024 15:57
@Bullrich
Copy link
Contributor

My last PR was merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants