Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pallet-grandpa to use v2 benchmarks #6073

Merged
merged 6 commits into from
Oct 29, 2024

Conversation

rockbmb
Copy link
Contributor

@rockbmb rockbmb commented Oct 15, 2024

Description

This PR moves the pallet-grandpa to the v2 of frame_benchmarking.
I submitted PR #6025 as an external contributor from my own fork, so I made this one from within this repo to see how the process would change.

Integration

N/A

Review Notes

Same as #6025, straightforward.

@rockbmb rockbmb added I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. T14-system_parachains This PR/Issue is related to system parachains. labels Oct 15, 2024
@rockbmb rockbmb self-assigned this Oct 15, 2024
@rockbmb rockbmb marked this pull request as ready for review October 15, 2024 13:17
@ggwpez ggwpez mentioned this pull request Oct 23, 2024
44 tasks
@shawntabrizi shawntabrizi added this pull request to the merge queue Oct 29, 2024
Merged via the queue into master with commit a42dcbf Oct 29, 2024
193 of 195 checks passed
@shawntabrizi shawntabrizi deleted the grandpa-benchmarks-v2-refactor branch October 29, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I4-refactor Code needs refactoring. T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. T14-system_parachains This PR/Issue is related to system parachains.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants