Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate pallet-nis benchmark to v2 #6293

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Migrate pallet-nis benchmark to v2 #6293

wants to merge 2 commits into from

Conversation

AurevoirXavier
Copy link
Contributor

@AurevoirXavier AurevoirXavier requested a review from a team as a code owner October 30, 2024 15:12
@AurevoirXavier AurevoirXavier mentioned this pull request Oct 30, 2024
Open
44 tasks
@re-gius re-gius added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels Nov 14, 2024
re-gius
re-gius approved these changes Nov 14, 2024
View reviewed changes
substrate/frame/nis/src/benchmarking.rs
@@ -19,8 +19,7 @@

#![cfg(feature = "runtime-benchmarks")]

use super::*;
use frame_benchmarking::v1::{account, benchmarks, whitelisted_caller, BenchmarkError};
use frame_benchmarking::{v2::*, BenchmarkError};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use frame_benchmarking::{v2::*, BenchmarkError};
use frame_benchmarking::v2::*;

@re-gius
Copy link
Contributor

re-gius commented Nov 14, 2024

/cmd prdoc --bump patch --audience runtime_dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@re-gius re-gius re-gius approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AurevoirXavier @re-gius @actions-user