Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove network starter that is no longer needed #6400

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

nazar-pc
Copy link
Contributor

@nazar-pc nazar-pc commented Nov 7, 2024

Description

This seems to be an old artifact of the long closed paritytech/substrate#6827 that I noticed when working on related code earlier.

Integration

NetworkStarter was removed, simply remove its usage:

-let (network, system_rpc_tx, tx_handler_controller, start_network, sync_service) =
+let (network, system_rpc_tx, tx_handler_controller, sync_service) =
    build_network(BuildNetworkParams {
...
-start_network.start_network();

Review Notes

Changes are trivial, the only reason for this to not be accepted is if it is desired to not start network automatically for whatever reason, in which case the description of network starter needs to change.

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: ask maintainers to put the right label on your PR.

@bkchr bkchr added the T0-node This PR/Issue is related to the topic “node”. label Nov 8, 2024
Copy link
Contributor

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bkchr
Copy link
Member

bkchr commented Nov 11, 2024

/cmd prdoc --audience node_dev --bump major

@bkchr bkchr enabled auto-merge November 11, 2024 09:36
@bkchr bkchr added this pull request to the merge queue Nov 11, 2024
Merged via the queue into paritytech:master with commit b601d57 Nov 11, 2024
192 of 197 checks passed
@nazar-pc nazar-pc deleted the remove-network-starter branch November 12, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out the situation with register_notifications_protocol
4 participants