-
Notifications
You must be signed in to change notification settings - Fork 690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release|CI/CD] Fix audiences changelog template #6444
Merged
EgorPopelyaev
merged 5 commits into
paritytech:master
from
EgorPopelyaev:ep-fix-audience-changelog-template
Nov 12, 2024
Merged
[Release|CI/CD] Fix audiences changelog template #6444
EgorPopelyaev
merged 5 commits into
paritytech:master
from
EgorPopelyaev:ep-fix-audience-changelog-template
Nov 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto ep-fix-audience-changelog-template
EgorPopelyaev
added
R0-silent
Changes should not be mentioned in any release notes
A4-needs-backport
Pull request must be backported to all maintained releases.
labels
Nov 11, 2024
alvicsam
approved these changes
Nov 11, 2024
…nto ep-fix-audience-changelog-template
mutantcornholio
approved these changes
Nov 12, 2024
ordian
approved these changes
Nov 12, 2024
michalkucharczyk
approved these changes
Nov 12, 2024
Merged
via the queue into
paritytech:master
with commit Nov 12, 2024
34d2ff8
197 of 200 checks passed
Git push to origin failed for stable2407 with exitcode 1 |
Git push to origin failed for stable2409 with exitcode 1 |
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 13, 2024
This PR addresses an issue mentioned [here](#6424 (comment)). The problem was that when the prdoc file has two audiences, but only one description like in [prdoc_5660](https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/1.16.0/pr_5660.prdoc) it was ignored by the template.
EgorPopelyaev
added a commit
that referenced
this pull request
Nov 13, 2024
This PR addresses an issue mentioned [here](#6424 (comment)). The problem was that when the prdoc file has two audiences, but only one description like in [prdoc_5660](https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/1.16.0/pr_5660.prdoc) it was ignored by the template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A4-needs-backport
Pull request must be backported to all maintained releases.
R0-silent
Changes should not be mentioned in any release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue mentioned here.
The problem was that when the prdoc file has two audiences, but only one description like in prdoc_5660 it was ignored by the template.