Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use core::error::Error and make the crate no-std #30

Merged
merged 1 commit into from
Nov 11, 2024
Merged

use core::error::Error and make the crate no-std #30

merged 1 commit into from
Nov 11, 2024

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Nov 8, 2024 •
edited
Loading

This PR changes:

  • Remove std feature and replace it with core::error::Error
  • Replace derive_more with thiserror (thiserror uses internally core::error::Error when rustc >= 1.81 is used)
  • Add MSRV 1.81

jsdw
jsdw approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@niklasad1 niklasad1 merged commit 82bb039 into main Nov 11, 2024
9 checks passed
@niklasad1 niklasad1 deleted the na-remove-std-error branch November 11, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lexnv lexnv lexnv approved these changes

@jsdw jsdw jsdw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklasad1 @jsdw @lexnv