Skip to content

Test prefix removal in the trie cache #2666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Test prefix removal in the trie cache #2666

wants to merge 1 commit into from

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 19, 2022

Tweaks the trie cache test in order to test prefix removal operations.

As I'm opening this PR, the test is failing, and it clearly indicates a bug in the trie cache.
Needs fixing.

mergify[bot]
mergify bot approved these changes Aug 19, 2022
View reviewed changes
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approving tomaka's pull requests. This auto-approval will be removed once more maintainers are active.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 19, 2022

twiggy diff report

Difference in .wasm size before and after this pull request.

 Delta Bytes │ Item
─────────────┼──────────────────
          +0 ┊ Σ [0 Total Rows]

melekes
melekes approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@melekes melekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomaka tomaka mentioned this pull request Sep 4, 2022
Merged
mergify bot added a commit that referenced this pull request Sep 5, 2022
@tomaka @mergify
Add some tests for remove_prefix (#2714)
52300a1 
Adds some tests regarding the code added in #2663

I wanted to maybe figure out why #2666 was failing, but didn't manage to find a failing case.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

+1 more reviewer

@melekes melekes melekes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tomaka @melekes