fix: staking payouts claimed with new logic & statuses #1457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is intended to be merged in this one #1436 and its changes are aligned with the
staking-info
updates from this PR #1445Changes
fetchCommissionAndLedger
tofetchCommissionLedgerAndClaimed
because it now also returnsclaimedRewards
.claimedRewards
is based on this PR for thestaking-info
endpoint.claimed
field returned fromstaking-payouts
is no longer a boolean value; It now has different statuses.undefined
was added which means that with the current information, we cannot determine if the rewards of the era were claimed, unclaimed or partially claimed.lastReward
and it is null, thenclaimed
is set toundefined
claimed
field, we wouldcontinue
/skip that era and do not return any info about that era. Now we don't, we just set the claimed field asundefined
.deriveEraPayouts
tofetchCommissionAndLedger
.era < 518
&& chain is Kusama is still working as expected. The era in this case is "automatically" considered asclaimed
.Testing
partially claimed
era### Todos
unclaimedOnly
to work with the new statuses.