This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Sassafras Protocol v0.3.2 #14139
Merged
Sassafras Protocol v0.3.2 #14139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
reviewed
May 15, 2023
| @@ -31,7 +31,7 @@ use sp_std::{fmt::Debug, vec::Vec}; | |||
| /// Typically, the implementers of this trait are its associated types themselves. | |||
| /// This provides a convenient way to access generic information about the scheme | |||
| /// given any of the associated types. | |||
| pub trait AppCrypto: 'static + Send + Sync + Sized + CryptoType + Clone { | |||
There was a problem hiding this comment.
AppCrypto is required to be implemented by any Pair and thus for the new bandersnatch::Pair as well.
Unfortunately bandersnatch_vrf::SecretKey embeds the SecretScalar (here) AND SecretScalar is defined to contain an UnsafeCell (here). Thus can't be Sync.
Nevertheless, Sync is not a hard requirement for our internals. So far, Send seems sufficient for all our use cases
|
(Not ready. Ignore the bogus review request...) |
|
The CI pipeline was cancelled due to failure one of the required jobs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Addresses paritytech/polkadot-sdk#41
Delivers:
bandersnatch-vrfsFlows into main Sassafras PR #11879