Skip to content

Commit

Permalink
Fix nits, remove WASM deps from nostd test, improve comments
Browse files Browse the repository at this point in the history
  • Loading branch information
jsdw committed Jan 29, 2025
1 parent 77dd23e commit c4c2ff3
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
4 changes: 4 additions & 0 deletions signer/src/sr25519.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@
// see LICENSE for license details.

//! An sr25519 keypair implementation.
//!
//! **Note:** This implementation requires the `getrandom` dependency to obtain randomness,
//! and will not compile on targets that it does not support. See the supported `getrandom`
//! targets here: <https://docs.rs/getrandom/latest/getrandom/#supported-targets>.
use core::str::FromStr;

Expand Down
3 changes: 0 additions & 3 deletions signer/tests/no-std/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ edition = "2021"
publish = false

[dev-dependencies]
wasm-bindgen-test = "0.3.24"
tracing-wasm = "0.2.1"
console_error_panic_hook = "0.1.7"

# This crate is not a part of the workspace, because we want to
# enable the "web" feature here but don't want it enabled as part
Expand Down
2 changes: 1 addition & 1 deletion signer/tests/no-std/tests/no_std.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#[no_std]
#![no_std]

use subxt_signer::{ecdsa, eth, sr25519};

Expand Down
1 change: 1 addition & 0 deletions testing/no-std-tests/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ fn compile_test() {
subxt_metadata::Metadata::decode(&mut &METADATA[..]).expect("should be valid metadata");

// Subxt signer compiles (though nothing much works on this particular nostd target...):
// Supported targets: <https://docs.rs/getrandom/latest/getrandom/#supported-targets>
use core::str::FromStr;
let _ = subxt_signer::SecretUri::from_str("//Alice/bar");

Expand Down

0 comments on commit c4c2ff3

Please sign in to comment.