-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add balances::transferAllowDeath
#299
Conversation
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1 |
…k-transfer-allow-death
PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Updating the metadata to v9430 for kusama caused some type issue when trying to minimize the metadata in any of the metadata functions. Therefore I needed to revert some of the metadata to a v9420 version, and it just worked out since I had to add the polkadot metadata for democracy::vote. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the comment! Looks great!
This adds
transferAllowDeath
which is to replacebalances::transfer
.I switched the metadata to v9420 but it still doesn't recognize
transferAllowDeath
, which is weird so the tests are failing.