Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add balances::transferAllowDeath #299

Merged
merged 8 commits into from
Jun 30, 2023
Merged

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented May 5, 2023

This adds transferAllowDeath which is to replace balances::transfer.

I switched the metadata to v9420 but it still doesn't recognize transferAllowDeath, which is weird so the tests are failing.

@TarikGul TarikGul requested a review from a team as a code owner May 5, 2023 18:40
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

@TarikGul
Copy link
Member Author

PR is ready for review.

Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@TarikGul
Copy link
Member Author

Updating the metadata to v9430 for kusama caused some type issue when trying to minimize the metadata in any of the metadata functions. Therefore I needed to revert some of the metadata to a v9420 version, and it just worked out since I had to add the polkadot metadata for democracy::vote.

Copy link
Collaborator

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the comment! Looks great!

@Imod7 Imod7 merged commit d96fe8c into main Jun 30, 2023
3 checks passed
@Imod7 Imod7 deleted the tarik-transfer-allow-death branch June 30, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants