-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rename state{mint, mine} to asset-hub-* #307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
@@ -22,12 +22,14 @@ export function getRegistryStatemine( | |||
}, | |||
specTypes: getSpecTypes( | |||
new TypeRegistry(), | |||
'Statemine', | |||
'Asset Hub Kusama', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO things like this make the transition confusing because this is actually not Asset hub Kusama
since the metadata passed in does not recognize asset-hub yet. Which means we would need to do 2 PR's that properly change over everything. We should really keep this to what is defined in the metadata, and hold off on having 2 different names here.
My question here would be does getSpecTypes
recognize Asset Hub Kusama
?
When we look at the above code, we still only recognize statemine, and statemint (You referenced this in your above exceptions). So I think the best way we can approach this is to add That way all the specNames are covered. |
I added |
Changes
Following the changes made in the Cumulus PR Rename Statemint to Asset Hub #2633, the following renamings were made in txwrapper-core :
statemint
->asset-hub-polkadot
/assetHubPolkadot
/ASSET_HUB_POLKADOT
depending on the instancestatemine
->asset-hub-kusama
/assetHubKusama
/ASSET_HUB_KUSAMA
depending on the instanceExceptions
No renamings were made in :
statemint
andstatemint
references in this index.ts filespecNameAdjusted
in this linestatemine
reference hereSince they all refer to the
specName
and as mentioned in the PR description this does not change.