feat(txwrapper-dev): export WESTEND_SPEC_VERSION constant
#313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR is related to this issue |
TarikGul
approved these changes
Jul 5, 2023
|
You will need to resolve the conflicts first by pulling in |
EmilIvanichkovv
force-pushed
the
feat/export-WESTEND_SPEC_VERSION
branch
4 times, most recently
from
1516228
to
2892fd6
Compare
EmilIvanichkovv
force-pushed
the
feat/export-WESTEND_SPEC_VERSION
branch
from
2892fd6
to
bbeff23
Compare
|
I think the tests are a bit flaky. Can you restart them? |
It's actually a side affect of having multiple metadata files. We are looking for the source of the issue in jest, but it went away when we stopped having multiple metadata sources and stuck with a single source of truth, but recently we realized we need 1 of each chain which brought back the issue to some extent. |
EmilIvanichkovv
force-pushed
the
feat/export-WESTEND_SPEC_VERSION
branch
from
bbeff23
to
24bf65d
Compare
|
Rebased and ready to merge too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose this change because I intend to utilize the
getRegistryWestendfunction outside this repository. I prefer to rely solely on data from the package, rather than creating a separate constant in my project.