Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(txwrapper-dev): Add @polkadot/api dependency #315

Merged

Conversation

EmilIvanichkovv
Copy link
Contributor

As outlined in this issue, our intention is to utilize the @substrate/txwrapper-dev package as a standalone package. However, during the development process, we observed that it has dependencies on packages that are not explicitly listed as dependencies.

  • @polkadot/types
  • @polkadot/types-known
  • @polkadot/networks
  • @polkadot/api
  • @polkadot/util-crypto
╰─➤ rg --no-filename -o "from '[^.](.*)'" ./packages/txwrapper-dev/ | sort | uniq

from 'memoizee'
from '@polkadot/api'
from '@polkadot/networks'
from '@polkadot/types'
from '@polkadot/types/extrinsic/signedExtensions/types'
from '@polkadot/types-known'
from '@polkadot/types/metadata/MetadataVersioned'
from '@polkadot/types/types'
from '@polkadot/util-crypto'

I suggest adding the @polkadot/api pkg as a dependencie to @substrate/txwrapper-dev

@EmilIvanichkovv EmilIvanichkovv requested a review from a team as a code owner July 5, 2023 12:09
@TarikGul
Copy link
Member

TarikGul commented Jul 5, 2023

Yea, I am okay with this change.

I would suggest running the following commands:

$ yarn up @polkadot/*
$ yarn dedupe

This will ensure all the versions of polkadot are the same.

@EmilIvanichkovv EmilIvanichkovv force-pushed the fix/txrapper-dev-dependencies branch 5 times, most recently from 474e4da to 05fab63 Compare July 5, 2023 14:01
@EmilIvanichkovv EmilIvanichkovv changed the title fix(txwrapper-dev): Add @polkadot/api dependencie fix(txwrapper-dev): Add @polkadot/api dependency Jul 5, 2023
Copy link
Collaborator

@Imod7 Imod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@EmilIvanichkovv
Copy link
Contributor Author

I think this is ready to be merged

@TarikGul TarikGul merged commit 2e19ac5 into paritytech:main Jul 5, 2023
3 checks passed
@EmilIvanichkovv EmilIvanichkovv deleted the fix/txrapper-dev-dependencies branch July 6, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants