Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update polkadot-js #329

Merged
merged 4 commits into from
Oct 17, 2023
Merged

chore(deps): update polkadot-js #329

merged 4 commits into from
Oct 17, 2023

Conversation

TarikGul
Copy link
Member

@TarikGul TarikGul commented Oct 14, 2023 •
edited
Loading

This PR updates polkadot-js to the latest versions:

Some notable changes: I type casted blockHash and genesisHash to ensure the compiler is happy with the most recent changes to from string -> 0x${string}.

I also ensured that toSpecifiedCallsOnlyV14 is only compatible with V14 metadata and not V15 so that is doesnt break for users.

@TarikGul TarikGul marked this pull request as ready for review October 17, 2023 14:13
@TarikGul TarikGul requested a review from a team as a code owner October 17, 2023 14:13
bee344
bee344 approved these changes Oct 17, 2023
View reviewed changes
Copy link
Collaborator

@bee344 bee344 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@TarikGul TarikGul merged commit f0b4850 into main Oct 17, 2023
8 checks passed
@TarikGul TarikGul deleted the tarik-up-pjs branch October 17, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bee344 bee344 bee344 approved these changes

@marshacb marshacb marshacb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TarikGul @marshacb @bee344