Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update PJS #404

Merged
merged 13 commits into from
Sep 18, 2024
Merged

chore(deps): Update PJS #404

merged 13 commits into from
Sep 18, 2024

Conversation

bee344
Copy link
Collaborator

@bee344 bee344 commented Sep 17, 2024

Description

Updating PJS/API to 13.1.1 brought changes with the type of the assetId used in the SignerPayloadJSON: now it's no longer a number or an object but a HexString. In order to conform to this, we changed the way the payload is buitl, first creating the correct type for the assetId (Compact<u32> or Multilocation) and then converting it to a hex string.

@bee344 bee344 changed the title chore: Update PJS [WIP] chore(deps): Update PJS [WIP] Sep 17, 2024
@bee344 bee344 marked this pull request as ready for review September 18, 2024 12:59
@bee344 bee344 requested a review from a team as a code owner September 18, 2024 12:59
@bee344 bee344 changed the title chore(deps): Update PJS [WIP] chore(deps): Update PJS Sep 18, 2024
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Really nice job!

Copy link
Collaborator

@marshacb marshacb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! lgtm

@bee344 bee344 merged commit f46f9c5 into main Sep 18, 2024
8 checks passed
@bee344 bee344 deleted the anp-asset-id branch September 18, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants