-
-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Replace dtslint with eslint #2453
Conversation
Thanks for opening this pull request! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha #2453 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6256 6256
Branches 1476 1451 -25
=========================================
Hits 6256 6256 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one; so should this be disabled in the CI for now, or how should we go about it to keep the CI green.
@mtrezza I supressed the error it should be good now. |
Pull Request
Issue
Replaces type check. See reason parse-community/parse-server#9581
Closes: #2435
Approach
Uses eslint-plugin-expect-type for type checking
dtslint only allowed for 1 file but with this change we can have individual test files for every typescript file.