-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul of Parse Server Guide #809
base: gh-pages
Are you sure you want to change the base?
Conversation
Any further comments around this PR @TomWFox 😊 |
I kind of thought I'd submitted a review on this but clearly not, it's still pending! |
No worries @TomWFox. No rush at all. If you have bulk changes suggested I can happily share my branch with you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats what I've got so far...
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
This reverts commit db0fd81.
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Before merging, I'll have to go back through again and add changes to the GitHub readme, such as Localization. |
I have looked it all over now so we're getting there 😀 |
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
Co-authored-by: Tom Fox <13188249+TomWFox@users.noreply.github.com>
I've added Localization but I couldn't get the table to format. Are markdown tables supported or do we need to reformat? |
Keep the empty lines before and after the table. Empty lines are missing at many places of the Localization part that you pasted. Try to keep the content and copy/paste without much modification, because empty lines are important in MD. |
Table formatting for the GitHub MD interpreter is a topic on its own - but it's possible. If you're interested, see here why. |
Markdown tables are not fun, learnt that the hard way! Edit: feel free to play around with it but my guess is that a different format will work best here |
I agree with different format, like in the API docs. I also think this would be better placed in the docs than in the README. |
Is this ready for another review? |
Yes plz 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few wee bits...
|
||
| Parameter | Optional | Type | Default value | Example values | Environment variable | Description | | ||
|----------------------------|----------|-----------------|---------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-----------------------------------------------|-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| `idempotencyOptions` | yes | `Object` | `undefined` | | PARSE_SERVER_EXPERIMENTAL_IDEMPOTENCY_OPTIONS | Setting this enables idempotency enforcement for the specified paths. | | ||
| `idempotencyOptions.paths` | yes | `Array<String>` | `[]` | `.*` (all paths, includes the examples below), <br>`functions/.*` (all functions), <br>`jobs/.*` (all jobs), <br>`classes/.*` (all classes), <br>`functions/.*` (all functions), <br>`users` (user creation / update), <br>`installations` (installation creation / update) | PARSE_SERVER_EXPERIMENTAL_IDEMPOTENCY_PATHS | An array of path patterns that have to match the request path for request deduplication to be enabled. The mount path must not be included, for example to match the request path `/parse/functions/myFunction` specifiy the path pattern `functions/myFunction`. A trailing slash of the request path is ignored, for example the path pattern `functions/myFunction` matches both `/parse/functions/myFunction` and `/parse/functions/myFunction/`. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have lost some of the extra info provided in this table.
@mtrezza you're better placed to comment on the importance of this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There have been no changes to the feature, the table's content should remain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe hold off addressing this until #809 (comment) has been resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good restructuring, just some formatting...
|
||
The following parameter and placeholder keys are reserved because they are used related to features such as password reset or email verification. They should not be used as translation keys in the JSON resource or as manually defined placeholder keys in the configuration: `appId`, `appName`, `email`, `error`, `locale`, `publicServerUrl`, `token`, `username`. | ||
|
||
### Parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in favor of this format, IMO harder to read than the table. Can we find something better visually structured? Edit: I am referring to the "Parameters" paragraph.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially naive question - is this something that is or can be documented in the api reference?
@@ -0,0 +1,9 @@ | |||
# Want to ride the bleeding edge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need an extra page for 1 sentence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could perhaps remove this entirely as it's 'how to use npm packages' info rather than 'how to use Parse Server'.
Anyone that doesn't know about how to use the master branch before reading this probably shouldn't be anyway.
This PR is intended to replace the README of the Parse Server repo, ensuring that all documentation is in one place.
I personally think that the README of the Parse Server repo should be stripped back to capture what Parse Server is about in a few lines, and then point to the docs for the most updated references.
Not sure if we want the contributors / sponsors on the site as well - I think it's a nice touch.
Closes #808