Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for asynchronous invocation of FilesAdapter.getFileLocation #9271

Merged
merged 10 commits into from
Aug 27, 2024
Merged

feat: Add support for asynchronous invocation of FilesAdapter.getFileLocation #9271

merged 10 commits into from
Aug 27, 2024

Conversation

vahidalizad
Copy link
Contributor

Pull Request

Issue

Closes: #9268

Approach

Added async support to FilesAdapter.getFileLocation.

Tasks

  • Added async support to FilesAdapter.getFileLocation.

@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

This was referenced Aug 10, 2024
Open
Open
mtrezza
mtrezza requested changes Aug 11, 2024
View reviewed changes
spec/FilesController.spec.js Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Aug 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (2a63129) to head (dbbe455).
Report is 2 commits behind head on alpha.

Additional details and impacted files 
@@            Coverage Diff             @@
##            alpha    #9271      +/-   ##
==========================================
- Coverage   93.48%   93.48%   -0.01%     
==========================================
  Files         186      186              
  Lines       14806    14807       +1     
==========================================
  Hits        13842    13842              
- Misses        964      965       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtrezza mtrezza changed the title fix: Added async support to FilesAdapter.getFileLocation feat: Added async support to FilesAdapter.getFileLocation Aug 13, 2024
@mtrezza mtrezza changed the title feat: Added async support to FilesAdapter.getFileLocation feat: Add support for asynchronous invocation of FilesAdapter.getFileLocation Aug 13, 2024
@vahidalizad
Copy link
Contributor Author

I haven't made any changes to the logic files just added tests for more coverage and the previous run was successful for all tests. Now, we're seeing failing CIs outside of the ParseObject tests. Can anyone help me understand why this might be happening?

@mtrezza
Copy link
Member

mtrezza commented Aug 14, 2024

The tests are now randomized, that may be a reason. If they are unrelated to this PR no worries, they may just be flaky. I'll rerun the CI, and they should pass at some point.

mtrezza
mtrezza reviewed Aug 16, 2024
View reviewed changes
spec/FilesController.spec.js Outdated Show resolved Hide resolved
src/Routers/UsersRouter.js Outdated Show resolved Hide resolved
mtrezza
mtrezza approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's wait for CI to pass...

@vahidalizad
Copy link
Contributor Author

Looks good, let's wait for CI to pass...

Could you run that failed test again? I believe it should pass, as the failure seems unrelated to this PR.

@vahidalizad
Copy link
Contributor Author

Looks good, let's wait for CI to pass...

Great, now that everything is settled, when do you think we can release this? I'd like to get back to the AWS S3 Adapter PR: refactor: Migrate S3 Client from AWS SDK v2 to v3.

@mtrezza
Copy link
Member

mtrezza commented Aug 22, 2024

Sorry for the delay here; this is good to merge, we just need to wait because the alpha branch is currently locked. I hope we can merge on the weekend.

@mtrezza mtrezza merged commit 1a2da40 into parse-community:alpha Aug 27, 2024
27 checks passed
parseplatformorg pushed a commit that referenced this pull request Aug 27, 2024
@semantic-release-bot
chore(release): 7.3.0-alpha.7 [skip ci]
e944616 
# [7.3.0-alpha.7](7.3.0-alpha.6...7.3.0-alpha.7) (2024-08-27)

### Features

* Add support for asynchronous invocation of `FilesAdapter.getFileLocation` ([#9271](#9271)) ([1a2da40](1a2da40))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 7.3.0-alpha.7

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released-alpha Released as alpha version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for async FilesAdapter.getFileLocation
3 participants
@vahidalizad @mtrezza @parseplatformorg