Refactor + Fix for making table headers #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
In the query response, not all keys may be present, leading to columns in the displayed table having mismatching headers, as these headers are derived from the keys of the first record.
Fix:
Determining headers on two scenarios:
When the query includes '*', indicating the selection of all columns, headers are generated from the schema by mapping parseable data types to Grafana's own data types. Any gaps are filled by iterating over the generated data frame.
If the query selectively chooses columns, headers are created from the first record, assuming that the SQL query results fill any gaps.