Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LtEqNum and GtEqNum ComparisonExpressions #203

Merged
merged 1 commit into from
Jul 26, 2017
Merged

LtEqNum and GtEqNum ComparisonExpressions #203

merged 1 commit into from
Jul 26, 2017

Conversation

jvdb
Copy link
Contributor

@jvdb jvdb commented Jul 26, 2017

Resolves #199.

@codecov
Copy link

codecov bot commented Jul 26, 2017 •
edited
Loading

Codecov Report

Merging #203 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master   #203   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      875    885   +10     
=======================================
  Files            87     89    +2     
  Lines          1253   1263   +10     
  Branches        142    142           
=======================================
+ Hits           1253   1263   +10
Impacted Files Coverage Δ Complexity Δ
...rsingdata/metal/expression/comparison/LtEqNum.java 100% <100%> (ø) 3 <3> (?)
...rsingdata/metal/expression/comparison/GtEqNum.java 100% <100%> (ø) 3 <3> (?)
.../src/main/java/io/parsingdata/metal/Shorthand.java 100% <100%> (ø) 127 <4> (+4) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bf0854...48814c8. Read the comment docs.

rdvdijk
rdvdijk approved these changes Jul 26, 2017
View reviewed changes
core/src/test/java/io/parsingdata/metal/ArgumentsTest.java
@@ -108,6 +113,12 @@
{ Not.class, new Object[] { null } },
// Derived from ComparisonExpression
{ Eq.class, new Object[] { VALID_VE, null } },
{ EqNum.class, new Object[] { VALID_VE, null } },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@jvdb jvdb merged commit aeef501 into master Jul 26, 2017
@jvdb jvdb deleted the lteqnum-and-gteqnum branch July 26, 2017 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdvdijk rdvdijk rdvdijk approved these changes

@TheUnknownCylon TheUnknownCylon Awaiting requested review from TheUnknownCylon

@ccreeten ccreeten Awaiting requested review from ccreeten

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvdb @rdvdijk