[Gen4] ble: clear connecting flag on connected for peripheral role #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
reviewed
Oct 17, 2024
| @@ -2381,6 +2381,7 @@ void BleGap::handleConnectionStateChanged(uint8_t connHandle, T_GAP_CONN_STATE n | |||
| LOG_DEBUG(TRACE, "Connected as Central"); | |||
| } else { | |||
| connection.info.role = BLE_ROLE_PERIPHERAL; | |||
| connecting_ = false; | |||
There was a problem hiding this comment.
Should the check at https://github.com/particle-iot/device-os/pull/2839/files#diff-f291a584aa5be86f324f9fa672da24a8055116bbe0194745178ab5eb74ce25f7R2403 just handle both cases once we generate appropriate events etc?
There was a problem hiding this comment.
When the device is acting as BLE peripheral, the device won't initiate the ATT MTU updating process, thus, that it won't hit that check, unless the BLE central device initiates the process. Under some circumstances, the BLE central device may omit this process. But for Gen4 platform that acts as BLE central role, from what we observed, it always initiates the process.
avtolstoy
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a device is connected as BLE peripheral, it cannot connect to a BLE periperhal device.
Solution
Reset the
connecting_flag on connected as BLE peripheral.References
https://community.particle.io/t/ble-fails-to-connect-to-peripheral-as-central-after-connecting-as-a-peripheral-to-iphone/68477?u=ielec
Completeness