Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wifi configuration on serial #736

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

keeramis
Copy link
Contributor

Description

Run serial wifi configuration via control requests for gen3 and above. Use serial commands for gen2.

How to Test

  1. Setup this branch
  2. Connect a single or multiple devices
  3. Run the following commands
    npm start -- serial wifi
    npm start -- serial wifi --file creds.json
    where creds.json looks like
{
  "network": "my_ssid",
  "security": "WPA2_AES",
  "password": "my_password"
}

Related Issues / Discussions

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@keeramis keeramis changed the title Fix/wifi control requests Fix wifi configuration May 14, 2024
@keeramis keeramis force-pushed the fix/wifi-control-requests branch from e797c17 to c45c060 Compare May 14, 2024 11:37
@keeramis keeramis requested review from hugomontero and monkbroc May 14, 2024 11:37
@keeramis keeramis changed the title Fix wifi configuration Fix wifi configuration on serial May 14, 2024
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it makes sense to use generation/version check since we need to ask questions to users so it's harder to do feature detection.

@hugomontero
Copy link
Contributor

hugomontero commented May 14, 2024

Control requests prevents the user to pre-configure the wifi if the SSID is not present on the area.
The use case that made us to rollback the first change was:
On production line some costumers requires to pre-configure the wifi credentials the devices will use in the work area. (the devices for this use case were P2/Photon2)

@keeramis keeramis force-pushed the fix/wifi-control-requests branch from 309d984 to bb45b96 Compare May 15, 2024 06:08
@monkbroc
Copy link
Member

Good call Hugo. Keerthy changed the fix to use control requests for DVOS >6 (since serial commands are gone there) and she'll figure out with Scott a better solution.

@keeramis keeramis force-pushed the fix/wifi-control-requests branch from 4158de3 to af9f90d Compare May 15, 2024 20:58
@keeramis keeramis merged commit 6a0eb44 into master May 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants