Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/sc-127966/cleanup-after-cli-release #740

Merged
merged 4 commits into from
May 21, 2024
Merged

feature/sc-127966/cleanup-after-cli-release #740

merged 4 commits into from
May 21, 2024

Conversation

hugomontero
Copy link
Contributor

@hugomontero hugomontero commented May 20, 2024 •
edited
Loading

Description

This PR will add coverage for update-cli and update-checks functions that has changed due the cli packaging updates we did before

How to Test

  1. Pull down the branch: git pull && git checkout feature/sc-127966/cleanup-after-cli-release
  2. Install dependencies: npm i
  3. Run tests: npm test
  4. Package the installer with a new package version (less that the 3.23.6): npm run build -- target host
  5. Attempt to use the update command: ./particle-cli update-cli

outcome

  • Tests should pass
  • The update should still work

Related Issues / Discussions

Story details: https://app.shortcut.com/particle/story/127966/cleanup-after-cli-release

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@hugomontero hugomontero changed the title Feature/sc 127966/cleanup after cli release feature/sc-127966/cleanup-after-cli-release May 20, 2024
@hugomontero hugomontero requested review from monkbroc and keeramis May 20, 2024 21:47
monkbroc
monkbroc approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@monkbroc monkbroc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@hugomontero hugomontero merged commit dabc3d1 into master May 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monkbroc monkbroc monkbroc approved these changes

@keeramis keeramis Awaiting requested review from keeramis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomontero @monkbroc