Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScriptin formatointi #82

Merged
merged 3 commits into from
Feb 4, 2025
Merged

JavaScriptin formatointi #82

merged 3 commits into from
Feb 4, 2025

Conversation

ilesoft
Copy link
Contributor

@ilesoft ilesoft commented Dec 21, 2024

Ajoin noihin /kipamedia:sta löytyviin ei-jQuery-tiedostoihin prettierin oletusasetuksilla. Jossain kohtaa voidaan miettiä että halutaanko tämäkin ottaa osaksi CI-tarkastuksia.

Copy link
Member

@vaaralav vaaralav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Tässäkin voisi olla paikallaan git blame ignore revs kun muutetaan vain formatointia eikä koodia

@ilesoft
Copy link
Contributor Author

ilesoft commented Dec 23, 2024

👍

Tässäkin voisi olla paikallaan git blame ignore revs kun muutetaan vain formatointia eikä koodia

Totta. Unohdin kommentoida tämän tuohon kuvakseen. Eli siis lisäys tehdään vasta sitten, kun tätä ei enää rebaseteta, eli kun nuo "alla" olevat PR:ät saadaan mergettyä ensin.

@ilesoft ilesoft force-pushed the linter2 branch 2 times, most recently from ac1b928 to 37ddb2f Compare February 4, 2025 13:57
Base automatically changed from linter2 to develop February 4, 2025 14:06
@ilesoft ilesoft merged commit 92d0856 into develop Feb 4, 2025
4 checks passed
@ilesoft ilesoft deleted the format-javascript branch February 4, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants