Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eval support to cli and repl #9

Merged
merged 3 commits into from
May 25, 2023
Merged

Add eval support to cli and repl #9

merged 3 commits into from
May 25, 2023

Conversation

alancai98
Copy link
Member

@alancai98 alancai98 commented May 2, 2023

Adds eval support to the CLI and REPL. Also makes the following changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@am357 am357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding eval to the REPL and all the other fixes. It's great!
Left one comment regarding the Bug related to the delimited queries with ;.

src/repl.rs Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@5db8418). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##             main      #9   +/-   ##
======================================
  Coverage        ?   0.15%           
======================================
  Files           ?       7           
  Lines           ?     647           
  Branches        ?       0           
======================================
  Hits            ?       1           
  Misses          ?     646           
  Partials        ?       0           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jpschorr jpschorr merged commit 1d35d45 into main May 25, 2023
@jpschorr jpschorr deleted the eval-support branch May 25, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants