(PC-34397)[PRO] feat: use localStorage to never display headline offer banner again once closed #16209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 68ba953): https://pc-pro-testing--pr16209-pc-34397-headline-of-e2lkw8rs.web.app (expires Fri, 14 Feb 2025 16:32:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1 |
asaez-pass
force-pushed
the
PC-34397-headline-offer-banner-remember-close
branch
13 times, most recently
from
d770009 to
5afd9fe
Compare
…r banner again once closed
asaez-pass
force-pushed
the
PC-34397-headline-offer-banner-remember-close
branch
from
5afd9fe to
68ba953
Compare
abouabdallaoui-pass
approved these changes
Feb 13, 2025
rchaffal-pass
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-34397
Objectifs
Vérifications
J'ai mis à jour le fichier des plans de tests du portail pro si nécessaireJ'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et DataJ'ai ajouté des screenshots pour d'éventuels changements graphiques