Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json Output Support #20

Merged
merged 7 commits into from
Dec 30, 2022
Merged

Json Output Support #20

merged 7 commits into from
Dec 30, 2022

Conversation

speatzle
Copy link
Collaborator

Supersedes #7 and fixes #4

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@speatzle speatzle merged commit 9a2944c into main Dec 30, 2022
@speatzle speatzle deleted the feature-json-output branch December 30, 2022 15:29
This was referenced Dec 30, 2022
@Cisien
Copy link

Cisien commented Dec 30, 2022

Decrypting values should probably be opt-in when exporting json. I get a timeout when executing a list resource command on an underpowered VM with 512mb ram and 1 core. Additionally, I don't always need the secret values when querying results.

I need to extend the timeout to get this command to complete.

passbolt list resource -j
Error: Get Resource Getting Resource Secret: Doing Request: Request Context: context deadline exceeded

@speatzle
Copy link
Collaborator Author

@Cisien

Decrypting values should probably be opt-in when exporting json.

Hmm, i am Rather split if i want to have it opt in or opt out. Since in most cases you would want to have the password.

I get a timeout when executing a list resource command on an underpowered VM with 512mb ram and 1 core.

Well currently it fetches the secret for each resource separately which is a waste of time. I think i could get it to fetch those all in the initial resource request but i would have to update go-passbolt.

@Cisien
Copy link

Cisien commented Dec 31, 2022

If you decide to keep it opt out, it would be useful to be able to opt out :) (perhaps by leveraging the column filters?)

@speatzle
Copy link
Collaborator Author

If you decide to keep it opt out, it would be useful to be able to opt out :) (perhaps by leveraging the column filters?)

I made a issue to track this #24 before i forget. I am currently Pretty busy so ill implement this some time SoonTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON format
3 participants