Skip to content

Commit

Permalink
fix: some more pytest warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
nutrina committed Oct 18, 2024
1 parent 8b02492 commit 7d4e684
Showing 1 changed file with 28 additions and 29 deletions.
57 changes: 28 additions & 29 deletions api/registry/test/test_data_science_bulk_score.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,48 +45,47 @@ def test_get_batch_analysis_stats_success(client, batch_requests, mocker):
mock_s3_client.generate_presigned_url.return_value = (
"https://example.com/presigned-url"
)
with mocker.patch("registry.api.v2.get_s3_client", return_value=mock_s3_client):
response = client.get(api_url, HTTP_AUTHORIZATION=settings.DATA_SCIENCE_API_KEY)
mocker.patch("registry.api.v2.get_s3_client", return_value=mock_s3_client)
response = client.get(api_url, HTTP_AUTHORIZATION=settings.DATA_SCIENCE_API_KEY)

assert response.status_code == 200
data = response.json()
assert response.status_code == 200
data = response.json()

assert len(data) == 10 # Default limit
assert all(isinstance(item, dict) for item in data)
assert len(data) == 10 # Default limit
assert all(isinstance(item, dict) for item in data)

for item in data:
assert "created_at" in item
assert "s3_url" in item
assert "status" in item
assert "percentage_complete" in item
for item in data:
assert "created_at" in item
assert "s3_url" in item
assert "status" in item
assert "percentage_complete" in item

# Check if the items are ordered by created_at in descending order
assert all(
data[i]["created_at"] >= data[i + 1]["created_at"]
for i in range(len(data) - 1)
)
# Check if the items are ordered by created_at in descending order
assert all(
data[i]["created_at"] >= data[i + 1]["created_at"] for i in range(len(data) - 1)
)

# Check if DONE requests have s3_url and others don't
for item in data:
if item["status"] == BatchRequestStatus.DONE.value:
assert item["s3_url"] == "https://example.com/presigned-url"
else:
assert item["s3_url"] is None
# Check if DONE requests have s3_url and others don't
for item in data:
if item["status"] == BatchRequestStatus.DONE.value:
assert item["s3_url"] == "https://example.com/presigned-url"
else:
assert item["s3_url"] is None


def test_get_batch_analysis_stats_with_limit(client, batch_requests, mocker):
mock_s3_client = mocker.Mock()
mock_s3_client.generate_presigned_url.return_value = (
"https://example.com/presigned-url"
)
with mocker.patch("registry.api.v2.get_s3_client", return_value=mock_s3_client):
response = client.get(
f"{api_url}?limit=5", HTTP_AUTHORIZATION=settings.DATA_SCIENCE_API_KEY
)
mocker.patch("registry.api.v2.get_s3_client", return_value=mock_s3_client)
response = client.get(
f"{api_url}?limit=5", HTTP_AUTHORIZATION=settings.DATA_SCIENCE_API_KEY
)

assert response.status_code == 200
data = response.json()
assert len(data) == 5
assert response.status_code == 200
data = response.json()
assert len(data) == 5


def test_get_batch_analysis_stats_unauthorized(client):
Expand Down

0 comments on commit 7d4e684

Please sign in to comment.