Skip to content

Removed flask in pathview package #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RemDelaporteMathurin merged 1 commit into from
Aug 15, 2025
Merged

Removed flask in pathview package #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 12 additions & 20 deletions src/python/pathsim_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@
FestimWall,
Integrator,
)
from flask import jsonify
import inspect

NAME_TO_SOLVER = {
Expand Down Expand Up @@ -275,32 +274,25 @@ def make_solver_params(solver_prms, eval_namespace=None):

for k, v in solver_prms.items():
if k not in ["Solver", "log"]:
try:
if v == "":
# TODO get the default from pathsim._constants
solver_prms[k] = None
else:
solver_prms[k] = eval(v, eval_namespace)
except Exception as e:
return jsonify(
{"error": f"Invalid value for {k}: {v}. Error: {str(e)}"}
), 400
if v == "":
# TODO get the default from pathsim._constants
solver_prms[k] = None
else:
solver_prms[k] = eval(v, eval_namespace)
elif k == "log":
if v == "true":
solver_prms[k] = True
elif v == "false":
solver_prms[k] = False
else:
return jsonify(
{"error": f"Invalid value for {k}: {v}. Must be 'true' or 'false'."}
), 400
raise ValueError(
f"Invalid value for {k}: {v}. Must be 'true' or 'false'."
)
elif k == "Solver":
if v not in NAME_TO_SOLVER:
return jsonify(
{
"error": f"Invalid solver: {v}. Must be one of {list(NAME_TO_SOLVER.keys())}."
}
), 400
raise ValueError(
f"Invalid solver: {v}. Must be one of {list(NAME_TO_SOLVER.keys())}."
)
solver_prms[k] = NAME_TO_SOLVER[v]

# remove solver duration from solver parameters
Expand Down Expand Up @@ -777,7 +769,7 @@ def make_pathsim_model(graph_data: dict) -> tuple[Simulation, float]:
try:
exec(python_code, eval_namespace)
except Exception as e:
return jsonify({"error": f"Error executing Python code: {str(e)}"}), 400
raise ValueError(f"Error executing custom Python code: {str(e)}")

solver_prms, extra_params, duration = make_solver_params(
solver_prms, eval_namespace
Expand Down
Loading