robo8x [chore] 1/1/2019, 6:38:51 PM

INSTALL.md

@@ -116,7 +116,7 @@ UrlToolkit {
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact) 
 

README.md

@@ -7,7 +7,7 @@
 
 
 
-# 🤖 P3X Gitlist - A decorated enhanced elegant, feature rich and modern private git ui repository viewer  v2019.1.1-15    
+# 🤖 P3X Gitlist - A decorated enhanced elegant, feature rich and modern private git ui repository viewer  v2019.1.1-16    
 
 
 This is an open-source project. Star this repository, if you like it, or even donate! Thank you so much! :)
@@ -138,7 +138,7 @@ December 31, 2018
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact) 
 

artifacts/php-7.2-ubuntu.md

@@ -20,7 +20,7 @@ sudo apt upgrade -y
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact) 
 

change-break.md

@@ -50,7 +50,7 @@ The following versions are not using `Babel`!!!! Yikes!
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact) 
 

changelog.md

@@ -9,12 +9,11 @@
 * added a variable: app.fixed_navbar in config.ini
   * you can set the navbar as fixed or not
 * added an alert when on the editor to let the users some people are not liking the full height editor mode and switch to the scroll mode 
-* the http user and git user with @ are replaced with %40
 * added a new ssh variable so that the ssh clone button can be dynamic like the http_user_dynamic called ssh_user_dynamic
 * renamed the git_clone_subdir to ssh_clone_subdir, it make most sense
 * in the git clone ssh button was missing the protocol (ssh://)
 * the RSS content type application/rss+xml is obsolete so I changed the content type to application/xml
-
+* the http_user and the ssh_user is url encoded
 
 ## v2018.12.31
 * config.ini changes
@@ -215,7 +214,7 @@ require('codemirror/mode/yaml/yaml');
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact) 
 

package.json

@@ -1,6 +1,6 @@
 {
     "name": "p3x-gitlist",
-    "version": "2019.1.1-16",
+    "version": "2019.1.1-17",
     "corifeus": {
         "prod-dir": "prod",
         "css-postfix": "333a67e1315d881bf5f6d3010d0c93828f294f24f7be203534d473210b0bd3ca",

src/GitList/Application.php

@@ -50,20 +50,17 @@ public function __construct(Config $config, $root = null)
         $this['show_http_remote'] = $config->get('clone_button', 'show_http_remote');
         $this['use_https'] = $config->get('clone_button', 'use_https');
         $this['ssh_clone_subdir'] = $config->get('clone_button', 'ssh_clone_subdir');
-        $this['http_user'] = $config->get('clone_button', 'http_user_dynamic') ? $_SERVER['PHP_AUTH_USER'] : $config->get('clone_button', 'http_user');
-
-        $this['http_user'] = str_replace('@', '%40', $this['http_user']);
 
-        $this['show_ssh_remote'] = $config->get('clone_button', 'show_ssh_remote');
 
         if (!isset($_SERVER['PHP_AUTH_USER'])) {
             $_SERVER['PHP_AUTH_USER'] = '';
         }
 
-        $this['ssh_user'] = $config->get('clone_button', 'ssh_user_dynamic') ? $_SERVER['PHP_AUTH_USER'] : $config->get('clone_button', 'ssh_user');
+        $this['http_user'] = $config->get('clone_button', 'http_user_dynamic') ? $_SERVER['PHP_AUTH_USER'] : $config->get('clone_button', 'http_user');
 
+        $this['show_ssh_remote'] = $config->get('clone_button', 'show_ssh_remote');
 
-        $this['ssh_user'] = str_replace('@', '%40', $this['ssh_user']);
+        $this['ssh_user'] = $config->get('clone_button', 'ssh_user_dynamic') ? $_SERVER['PHP_AUTH_USER'] : $config->get('clone_button', 'ssh_user');
 
         $this['git_http_subdir_calculated'] = $config->get('clone_button', 'git_http_subdir_calculated');
         $this['git_http_subdir'] = $config->get('clone_button', 'git_http_subdir');

src/twig/breadcrumb.twig

@@ -98,13 +98,13 @@
                         <input readonly
                                type="text" class="form-control{{ app.show_ssh_remote ? ' visible' }}"
                                id="clone-input-ssh"
-                               value="git clone ssh://{{ app.ssh_user }}{{ app.ssh_user ? '@' }}{{ global.request.host }}:{{ app.ssh_clone_subdir }}{{ repo }}">
+                               value="git clone ssh://{{ app.ssh_user | url_encode }}{{ app.ssh_user ? '@' }}{{ global.request.host }}:{{ app.ssh_clone_subdir }}{{ repo }}">
                     {% endif %}
                     {% if app.show_http_remote %}
                         <input type="text"
                                readonly class="form-control{{ app.show_ssh_remote is empty and app.show_http_remote ? ' visible' }}"
                                id="clone-input-http"
-                               value="git clone http{{ app.use_https ? 's' }}://{{ app.http_user }}{{ app.http_user ? '@' }}{{ global.request.host }}{{ app.git_http_subdir_calculated ? app.url_subdir : app.git_http_subdir }}/{{ repo }}">
+                               value="git clone http{{ app.use_https ? 's' }}://{{ app.http_user | url_encode }}{{ app.http_user ? '@' }}{{ global.request.host }}{{ app.git_http_subdir_calculated ? app.url_subdir : app.git_http_subdir }}/{{ repo }}">
                     {% endif %}
 
 

todo.md

@@ -32,7 +32,7 @@
 
 ---
 
-[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-15 
+[**P3X-GITLIST**](https://pages.corifeus.com/gitlist) Build v2019.1.1-16 
 
 [![Like Corifeus @ Facebook](https://img.shields.io/badge/LIKE-Corifeus-3b5998.svg)](https://www.facebook.com/corifeus.software) [![Donate for Corifeus / P3X](https://img.shields.io/badge/Donate-Corifeus-003087.svg)](https://www.paypal.com/cgi-bin/webscr?cmd=_s-xclick&hosted_button_id=QZVM4V6HVZJW6)  [![Contact Corifeus / P3X](https://img.shields.io/badge/Contact-P3X-ff9900.svg)](https://www.patrikx3.com/en/front/contact)