Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button)!: remove shadow <button> #2707

Merged
merged 9 commits into from
Mar 20, 2024

Conversation

bennypowers
Copy link
Member

@bennypowers bennypowers commented Mar 19, 2024

What I did

  1. remove the shadow <button> from pf-button
  2. implement (hopefully all of the) button semantics on the host
  3. refactor styles and whatnot to suit
  4. refactor pf-chip in response to button changes

Testing Instructions

  1. units, manual UX and SR testing on button and chip demos
  2. manual testing on form control demos (requestSubmit should call)

Notes to Reviewers

  1. I used css nesting, we might need to go back later and compile that out
  2. IMPORTANT: test failures on dropdown should be addressed in fix(dropdown): slotted trigger #2703 see fix(button)!: remove shadow <button> #2707 (comment)

Copy link

changeset-bot bot commented Mar 19, 2024

🦋 Changeset detected

Latest commit: f1ee6ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@patternfly/elements Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. styles An issue or PR pertaining only to CSS/Sass labels Mar 19, 2024
Copy link

netlify bot commented Mar 19, 2024

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit f1ee6ff
🔍 Latest deploy log https://app.netlify.com/sites/patternfly-elements/deploys/65f99f7dd5037c00087b7661
😎 Deploy Preview https://deploy-preview-2707--patternfly-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the AT passed Automated testing has passed label Mar 19, 2024
@github-actions github-actions bot added the tests Related to testing label Mar 19, 2024
@bennypowers
Copy link
Member Author

Failure on dropdown is likely related to dequelabs/axe-core#4259

If manual UX testing passes, I suggest we exclude this assertion and leave a comment with a link to that issue

Copy link
Collaborator

@nikkimk nikkimk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little Grogu the Mandalorian

@bennypowers
Copy link
Member Author

You could write a book with your lagtam's, Nikki

@bennypowers bennypowers merged commit b9bb7e3 into main Mar 20, 2024
17 checks passed
@bennypowers bennypowers deleted the fix/button/internals-no-shadow-button branch March 20, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT passed Automated testing has passed demo Updating demo pages functionality Functionality, typically pertaining to the JavaScript. ready to merge styles An issue or PR pertaining only to CSS/Sass tests Related to testing
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants