-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(button)!: remove shadow <button> #2707
Conversation
🦋 Changeset detectedLatest commit: f1ee6ff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Failure on dropdown is likely related to dequelabs/axe-core#4259 If manual UX testing passes, I suggest we exclude this assertion and leave a comment with a link to that issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Little Grogu the Mandalorian
You could write a book with your lagtam's, Nikki |
What I did
<button>
from pf-buttonTesting Instructions
Notes to Reviewers
IMPORTANT: test failures on dropdown should be addressed in fix(dropdown): slotted trigger #2703see fix(button)!: remove shadow <button> #2707 (comment)