Skip to content

Conversation

wise-king-sullyman
Copy link
Collaborator

Closes #4257

@patternfly-build
Copy link
Contributor

patternfly-build commented Dec 2, 2024

Copy link
Collaborator

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks good to me!

@edonehoo
Copy link
Collaborator

Looks good! Especially React/HTML pages

Only thing I noticed is that it seems like the spacing above some headings is a little larger (I think mainly h3 and h4's?) For example, here's the current spacing between two headings:

image

vs in this pr:

image

It's more obvious on text-heavy pages (like /about accessibility), but it's still subtle so I don't know if it really matters.

Either way, may be good for a designer's eye to agree with the spacing styling in general --- @andrew-ronaldson could you poke around the preview link and make sure everything feels good?

@kmcfaul
Copy link
Contributor

kmcfaul commented Apr 2, 2025

@wise-king-sullyman Looks like it needs a rebase before the build/synk clears

@wise-king-sullyman
Copy link
Collaborator Author

@mcoker were you planning on making any more changes to this after the previous feedback?

@mcoker
Copy link
Contributor

mcoker commented May 30, 2025

@wise-king-sullyman In a perfect world, yes, but I've been busy with other priority work. What are you thinking about handling this issue? Anything in particular you have a question about or would like me to look at?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug - Fix spacing issue that appears in React and HTML docs

5 participants