Skip to content

Bug #4808: Navigation sidebar closes on item selection for narrower screens #4814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bug #4808: Navigation sidebar closes on item selection for narrower screens #4814

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b6f1b
Bug #4808: Navigation sidebar closes on item selection for narrower s…
Zaki-Mohd Oct 3, 2025
1bea9fc
Bug #4808: Navigation sidebar closes on item selection for narrower s…
Zaki-Mohd Oct 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions packages/documentation-framework/components/sideNav/sideNav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ import { makeSlug } from '../../helpers';
import globalBreakpointXl from '@patternfly/react-tokens/dist/esm/t_global_breakpoint_xl';
import { trackEvent } from '../../helpers';

const mobileBreakpoint = Number(globalBreakpointXl.value.replace('px', ''));

const getIsActive = (location, section, subsection = null) => {
const slug = makeSlug(null, section, null, null, subsection);
return location.pathname.startsWith(slug);
Expand All @@ -24,14 +26,17 @@ const getIsActive = (location, section, subsection = null) => {
const defaultValue = 50;

const NavItem = ({ text, href, isDeprecated, isBeta, isDemo }) => {
const isMobileView = window.innerWidth < Number.parseInt(globalBreakpointXl.value, 10);
return (
<PageContextConsumer key={href + text}>
{({ onSidebarToggle, isSidebarOpen }) => (
{({ onNavToggle, isNavOpen }) => (
<li
key={href + text}
className="pf-v6-c-nav__item"
onClick={() => isMobileView && onSidebarToggle && onSidebarToggle()}
onClick={() => {
if (typeof window !== 'undefined' && onNavToggle && window.innerWidth < mobileBreakpoint) {
onNavToggle();
}
}}
>
<Link
to={href}
Expand All @@ -41,7 +46,7 @@ const NavItem = ({ text, href, isDeprecated, isBeta, isDemo }) => {
className: css('pf-v6-c-nav__link', (isCurrent || pathname.startsWith(href + '/')) && 'pf-m-current')
};
}}
tabIndex={isSidebarOpen ? undefined : -1}
tabIndex={isNavOpen ? undefined : -1}
>
<Flex spaceItems={{ default: 'spaceItemsSm' }}>
<FlexItem>{text}</FlexItem>
Expand Down