Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase v6 #195

Closed
wants to merge 3 commits into from
Closed

Rebase v6 #195

wants to merge 3 commits into from

Conversation

jenny-s51
Copy link
Collaborator

@jenny-s51 jenny-s51 commented May 16, 2024

What

Closes #194

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): rebase

Screen shots / Gifs for design review

@jenny-s51 jenny-s51 mentioned this pull request May 16, 2024
7 tasks
@jenny-s51 jenny-s51 changed the title Test rebase v6 Rebase v6 May 16, 2024
@jenny-s51 jenny-s51 force-pushed the main_copy branch 4 times, most recently from 81aeb12 to 6f8d3df Compare May 17, 2024 18:43
@patternfly-build
Copy link

patternfly-build commented May 22, 2024

@jenny-s51 jenny-s51 force-pushed the main_copy branch 3 times, most recently from 090445c to 4c9a83b Compare May 22, 2024 19:28
Copy link
Collaborator Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped alphas and docs framework version to fix build. Added react-error-overlay to package.json to resolve process is undefined error / blank UI state.

Currently the build is failing due to outdated token values that are used in multiple files. Those tokens will need to be updated to their v6 equivalents. Investigating this...

Copy link
Collaborator Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing, addressed via #199

@jenny-s51 jenny-s51 closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants