Draft: chore(179): Share resources between iOS and Android #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 23, 2024 15:30
martinbonnin
approved these changes
Feb 27, 2024
Comment on lines
+1
to
+6
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <Bucket | ||
| uuid = "9F7B89E4-5A4D-4E4C-A16E-817569E368B9" | ||
| type = "1" | ||
| version = "2.0"> | ||
| </Bucket> |
There was a problem hiding this comment.
Should that be in .gitignore? (given it contains usernames in paths)
martinbonnin
approved these changes
Feb 27, 2024
martinbonnin
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Added Moko Resources * Configured Moko on iOS * Plugged iOS strings to MP resources * Removed unused resources * Removed L10n from iOS --------- Co-authored-by: Antoine Robiez <antoine.robiez@worldline.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Moko Resources to the projet and shared iOS and Android font, images, colors and strings.
All the configuration is fine for me, I removed unused resources on Android and I started to share the strings.
Some strings are specific for iOS. I assume that they will be removed if we manage to go full Compose Multiplatform.