-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permit mocking stackable trait pattern in scala 3 #528
base: master
Are you sure you want to change the base?
Conversation
Maybe not the forum to say this, but other than #527 this was the only bug I've hit so far on migrating from scala 2 to scala 3, so absolutely incredible job on compatibility here. |
I appreciate there's a nuance here of 'do we really want to make it impossible to mock artifact methods?'. I think they're already essentially not unlockable? As in it would probably be pointless to try to use them in any mock. So I'm pretty sure that it's a legit forbid |
In my opinion, we shouldn't allow mocking this. |
shared/src/test/scala/org/scalamock/test/scalatest/AbstractOverrideMethodTest.scala
Show resolved
Hide resolved
10e72da
to
c2768d4
Compare
@goshacodes sorry for taking so long to get to this, pushed the changes -- hadn't realised it was as simple as adding a new case to the |
@barkhorn let's merge it |
Pull Request Checklist
Fixes
Fixes mocking classes that implement the stackable trait pattern (i.e.
abstract override def
) in scala 3