Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/step1 #23

Merged
merged 9 commits into from
Nov 22, 2024
Merged

Refactoring/step1 #23

merged 9 commits into from
Nov 22, 2024

Conversation

rea1991
Copy link
Contributor

@rea1991 rea1991 commented Nov 9, 2024

No description provided.

Use of a single-leading underscore as "internal use" indicator.
This was done to improve code clarity and allow unit testing of
the function.
This was done to improve code clarity and allow unit testing of the function.
This was done to improve code clarity and allow unit testing of the function.
Done to improve clarity:
- The code to extract and plot regions of interest is now inside the
  function _plot_RoIs
- A minor error is corrected: I_RoI is the region extracted from I,
  not Iproc
- Added some to-do for rea1991 and robomics
Some comments to functions related to step_1 are added, so that it
is easier to understand what's the purpose of each substep.
@rea1991 rea1991 added testing PRs modifying tests or test infrastructure refactor Rewriting code in better ways, e.g., to ease unit testing labels Nov 9, 2024
@rea1991 rea1991 requested a review from robomics November 9, 2024 15:04
@robomics robomics marked this pull request as draft November 9, 2024 15:08
@robomics robomics marked this pull request as ready for review November 22, 2024 12:50
Copy link
Contributor

@robomics robomics left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robomics robomics merged commit 689cbba into paulsengroup:main Nov 22, 2024
8 checks passed
@rea1991 rea1991 deleted the refactoring/step1 branch November 28, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Rewriting code in better ways, e.g., to ease unit testing testing PRs modifying tests or test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants