Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Stripe class #25

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Refactor Stripe class #25

merged 11 commits into from
Nov 22, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Nov 9, 2024 •
edited
Loading

Refactor the Stripe class with the following aims:

  • Improve error checking
  • Mark all fields as private and expose properties and stats using read-only attributes
  • Split computation into smaller functions
  • Add documentation
  • Make unit testing more straight forward

@robomics robomics added enhancement New feature or request testing PRs modifying tests or test infrastructure refactor Rewriting code in better ways, e.g., to ease unit testing labels Nov 9, 2024
@robomics robomics marked this pull request as draft November 9, 2024 15:08
@robomics robomics marked this pull request as ready for review November 22, 2024 14:21
@robomics robomics requested a review from rea1991 November 22, 2024 14:35
@rea1991 rea1991 merged commit 8c1b229 into paulsengroup:main Nov 22, 2024
8 checks passed
@robomics robomics deleted the refactoring/stripe branch November 22, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rea1991 rea1991 rea1991 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request refactor Rewriting code in better ways, e.g., to ease unit testing testing PRs modifying tests or test infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robomics @rea1991