Skip to content

Improve error messages issued upon failure of CLI argument type validation #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

robomics
Copy link
Contributor

Closes #78.

@robomics robomics added the enhancement New feature or request label Dec 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.48%. Comparing base (e40619a) to head (e819080).
Report is 167 commits behind head on main.

Files with missing lines Patch % Lines
src/stripepy/cli/setup.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #83   +/-   ##
=======================================
  Coverage   71.48%   71.48%           
=======================================
  Files          18       18           
  Lines        2108     2108           
=======================================
  Hits         1507     1507           
  Misses        601      601           
Flag Coverage Δ
[tests integration python-3.10](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.11](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.12](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.13](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.9](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.10](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.11](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.12](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.13](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.9](https://app.codecov.io/gh/paulsengroup/StripePy/pull/83/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rea1991 rea1991 merged commit 50b9d46 into paulsengroup:main Jan 6, 2025
16 checks passed
@robomics robomics deleted the feature/better-errors branch January 7, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] make errors message generated due to invalid CLI parameters more user-friendly
3 participants