Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[performance]: optimize find_HIoIs() #90

Closed
wants to merge 3 commits into from

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Jan 9, 2025

On my dev machine the optimization results in a 10% improvement in single-threaded performance.

@robomics robomics added the enhancement New feature or request label Jan 9, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 31.42857% with 24 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (8e96618) to head (2085f45).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/stripepy/utils/finders.py 34.61% 17 Missing ⚠️
src/stripepy/stripepy.py 0.00% 4 Missing ⚠️
src/stripepy/utils/regressions.py 40.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (8e96618) and HEAD (2085f45). Click for more details.

HEAD has 48 uploads less than BASE
Flag BASE (8e96618) HEAD (2085f45)
tests unit python-3.12
tests unit python-3.11
tests unit python-3.12
tests unit python-3.10
tests unit python-3.11
tests unit python-3.10
tests integration python-3.13
tests integration python-3.12
tests integration python-3.11
tests integration python-3.9
tests integration python-3.10
tests integration python-3.13
tests integration python-3.12
tests integration python-3.9
tests integration python-3.11
tests integration python-3.10
Additional details and impacted files
@@             Coverage Diff             @@
##             main      #90       +/-   ##
===========================================
- Coverage   85.31%   32.85%   -52.46%     
===========================================
  Files          19       19               
  Lines        2478     2490       +12     
===========================================
- Hits         2114      818     -1296     
- Misses        364     1672     +1308     
Flag Coverage Δ
[tests integration python-3.10](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.10
[tests integration python-3.11](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.11
[tests integration python-3.12](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.12
[tests integration python-3.13](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.13
[tests integration python-3.9](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests integration python-3.9
[tests unit python-3.10](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.10
[tests unit python-3.11](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.11
[tests unit python-3.12](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.12
[tests unit python-3.13](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.13
[tests unit python-3.9](https://app.codecov.io/gh/paulsengroup/StripePy/pull/90/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup)
[tests unit python-3.9

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics force-pushed the perf/optimization branch 2 times, most recently from e827f2f to 6fd3fb5 Compare January 9, 2025 13:36
The optimization result in a 10% improvement in single-threaded performance
@robomics robomics changed the title [performance]: optimize stripepy call [performance]: optimize find_HIoIs() Jan 10, 2025
@robomics robomics marked this pull request as ready for review January 10, 2025 11:23
@robomics
Copy link
Contributor Author

Superseded by #91

@robomics robomics closed this Jan 10, 2025
@robomics robomics deleted the perf/optimization branch January 14, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants