-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bug] Fix inconsistent results produced on different platforms #92
Open
robomics
wants to merge
6
commits into
paulsengroup:main
Choose a base branch
from
robomics:fix/portability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+131
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug that resulted in different results being returned when running stripepy call on different platform (and potentially even when using different versions of numpy and pandas). The bug was caused by not forcing numpy and pandas to use stable sorting algorithms. This resulted in slightly different results produced on macOS and Linux (Windows and Linux produced consistent results).
robomics
force-pushed
the
fix/portability
branch
from
January 13, 2025 13:22
344343e
to
fab2aa0
Compare
robomics
force-pushed
the
fix/portability
branch
3 times, most recently
from
January 13, 2025 16:02
a2ed928
to
c68b477
Compare
Basically we truncate pseudodistribution values at the 10th decimal place to avoid producing different results on different platforms/architectures due to minor difference in FP values.
robomics
force-pushed
the
fix/portability
branch
from
January 13, 2025 16:08
c68b477
to
62e3f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two bugs that resulted in different results being returned when running stripepy call on different platform (and potentially even when using different versions of numpy and pandas).
The first bug was caused by not forcing numpy and pandas to use stable sorting algorithms.
The second bug was due to minor difference in FP arithmetic on different architectures.
This first bug resulted in slightly different results produced on macOS and Linux (Windows and Linux produced consistent results).
The second bug resulted in different results when using different architectures (or even different CPUs with the same arch).